[App Search] Add roleHasScopedEngines helper + small roles/ cleanup
#94038
Conversation
- in preparation for new scoped engines helper
cee-chen
added
Feature:Plugins
release_note:skip
| export const roleHasScopedEngines = (roleType: RoleTypes): boolean => { | ||
| const unscopedRoles = ['dev', 'editor', 'analyst']; | ||
| return unscopedRoles.includes(roleType); | ||
| }; |
There was a problem hiding this comment.
This is the main new added utility/functionality (ported over from https://github.com/elastic/ent-search/blob/master/app/javascript/app_search/classes.ts#L10-L13)
| * Transforms the `role` data we receive from the Enterprise Search | ||
| * server into a more convenient format for front-end use | ||
| */ | ||
| export const getRoleAbilities = (role: Account['role']): Role => { |
There was a problem hiding this comment.
This fn is the exact same as before, I just moved the type definitions out into types.ts. The types are also the same as before
💚 Build SucceededMetrics [docs]Module Count
Async chunks
To update your PR or re-run it, just comment with: |
|
|
||
| import { roleHasScopedEngines } from './'; | ||
|
|
||
| describe('roleHasScopedEngines()', () => { |
There was a problem hiding this comment.
do not make this update for this PR, it's not worth running CI. Just noting that we usually don't add parens to the end of function names in describes.
| describe('roleHasScopedEngines()', () => { | |
| describe('roleHasScopedEngines', () => { |
There was a problem hiding this comment.
haha thanks Jason, I was totally about to smash commit suggestion before seeing the do not (italics totally worked). This is an accidental copypaste carry over from
- I think I originally added the
()because it's a function helper within a 'class'/obj that has static vars mixed in with fn's 🤔 not sure if the()is helpful in those scenarios - agreed they're not helpful for utility files where everything is a function
There was a problem hiding this comment.
@scottybollinger if you're down, feel free to make Jason's suggested copy change in a future role mappings PR!
…elastic#94038) * Split out roles/ into separate files - in preparation for new scoped engines helper * Add new roleHasScopedEngines helper
…#94038) (#94144) * Split out roles/ into separate files - in preparation for new scoped engines helper * Add new roleHasScopedEngines helper Co-authored-by: Constance <[email protected]>
Summary
@scottybollinger needs this helper for his App Search role mappings work.
Thanks to his great suggestion in #94032 (comment), I've moved this out of
myRoleto its own separate utility fn, and split up therole/folder some (into separate utils+types)Checklist